Skip to content

[Improve](serde) support text serde for nested type-array/map#22738

Merged
morningman merged 5 commits into
apache:masterfrom
amorynan:improve-serde-text-nested-support
Aug 21, 2023
Merged

[Improve](serde) support text serde for nested type-array/map#22738
morningman merged 5 commits into
apache:masterfrom
amorynan:improve-serde-text-nested-support

Conversation

@amorynan

@amorynan amorynan commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #xxx
Now we can not support nested type array/map
so this pr aim to:

  1. add format option for string convert defined datatype to keep with origin from_string
  2. support array map can nested array and map

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions

github-actions Bot commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions

github-actions Bot commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions

github-actions Bot commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@amorynan

amorynan commented Aug 9, 2023

Copy link
Copy Markdown
Contributor Author

run buildall

@github-actions

github-actions Bot commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen

hello-stephen commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.4 seconds
stream load tsv: 514 seconds loaded 74807831229 Bytes, about 138 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 30.5 seconds inserted 10000000 Rows, about 327K ops/s
storage size: 17161956730 Bytes

@github-actions

github-actions Bot commented Aug 9, 2023

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xy720

xy720 commented Aug 16, 2023

Copy link
Copy Markdown
Member

Please give me one day to review it.

@morningman

morningman commented Aug 18, 2023

Copy link
Copy Markdown
Contributor

run buildall

morningman
morningman approved these changes Aug 18, 2023
View reviewed changes

@morningman morningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we will merge it and test it later

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Aug 18, 2023
@github-actions

github-actions Bot commented Aug 18, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actions Bot commented Aug 18, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

xy720
xy720 approved these changes Aug 18, 2023
View reviewed changes

@xy720 xy720 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 33dfa0c into apache:master Aug 21, 2023
@amorynan amorynan mentioned this pull request Aug 25, 2023
Merged
@xiaokang xiaokang mentioned this pull request Aug 25, 2023
Merged
xiaokang pushed a commit that referenced this pull request Aug 25, 2023
[Improve](serde) support text serde for nested type-array/map pick from
8930f42 
#22738 (#23514)
@xiaokang xiaokang mentioned this pull request Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes
@xy720 xy720 xy720 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.1-merged merge_conflict reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@amorynan @hello-stephen @xy720 @morningman @xiaokang